show version from pyproject.toml file and show in in footer , the gi… - #27
Merged
Merged
Conversation
…t hash is also available and show as tooltip
also rewove font icons from the footer to get ride of Fix fa-brands-400.woff2
denkv
reviewed
Apr 16, 2026
|
|
||
| def get_version() -> str: | ||
| try: | ||
| with open("pyproject.toml", "rb") as f: |
Collaborator
There was a problem hiding this comment.
Does this work with a packaged version?
Collaborator
There was a problem hiding this comment.
from importlib.metadata import version, PackageNotFoundError
try:
return version('learn2rag')
except PackageNotFoundError:
return 'unknown'
denkv
reviewed
Sep 3, 2026
|
|
||
| def get_git_hash() -> str: | ||
| try: | ||
| return subprocess.check_output(['git', 'rev-parse', '--short', 'HEAD']).decode('ascii').strip() |
Collaborator
There was a problem hiding this comment.
text=True subprocess option instead of decode()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…t hash is also available and show as tooltip